Re: [PATCH v2] dt-bindings: iio: gyroscope: add mount-matrix for bmg160

[Vishwas Rajashekar]

On Thursday, April 16th, 2026 at 21:12, Conor Dooley <conor@xxxxxxxxxx> wrote:

> On Thu, Apr 16, 2026 at 08:33:21PM +0530, Vishwas Rajashekar via B4 Relay wrote:
> > From: Vishwas Rajashekar <vishwas.dev@xxxxxxxxxxxxx>
> > 
> > Adds mount-matrix as an optional property to dt-bindings
> > for the bmg160 gyroscope as the driver reads this optional
> > property during probe.
> 
> Ultimately, what the driver does is not relevant here. All that matters
> is that the property is relevant to the hardware. Please come up with a
> commit message that avoids mentioning linux drivers and instead explains
> why it is relevant to the hardware.
> 
> pw-bot: changes-requested
> 
> Cheers,
> Conor.
> 

Thank you for the feedback! I've updated the commit message in v3.

> > 
> > Signed-off-by: Vishwas Rajashekar <vishwas.dev@xxxxxxxxxxxxx>
> > ---
> > The bmg160 driver reads an optional mount-matrix using
> > "iio_read_mount_matrix" in "bmg160_core_probe" and stores
> > this orientation data in "struct bmg160_data". As the "mount-matrix"
> > property is used by the driver, this change proposes to add it to
> > the corresponding dt-bindings.
> > ---
> > Changes in v2:
> > - Addressed review feedback: add mount-matrix example for bmg160
> > - Link to v1: https://patch.msgid.link/20260415-bmg160-mount-matrix-dt-binding-v1-1-0e2c85964ee6@xxxxxxxxxxxxx
> > 
> > To: Jonathan Cameron <jic23@xxxxxxxxxx>
> > To: David Lechner <dlechner@xxxxxxxxxxxx>
> > To: Nuno Sá <nuno.sa@xxxxxxxxxx>
> > To: Andy Shevchenko <andy@xxxxxxxxxx>
> > To: Rob Herring <robh@xxxxxxxxxx>
> > To: Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>
> > To: Conor Dooley <conor+dt@xxxxxxxxxx>
> > To: "H. Nikolaus Schaller" <hns@xxxxxxxxxxxxx>
> > Cc: linux-iio@xxxxxxxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx
> > ---
> >  Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
> > index 3c6fe74af0b8..ec97778cca78 100644
> > --- a/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
> > +++ b/Documentation/devicetree/bindings/iio/gyroscope/bosch,bmg160.yaml
> > @@ -22,6 +22,9 @@ properties:
> >    vdd-supply: true
> >    vddio-supply: true
> >  
> > +  mount-matrix:
> > +    description: an optional 3x3 mounting rotation matrix.
> > +
> >    spi-max-frequency:
> >      maximum: 10000000
> >  
> > @@ -52,6 +55,9 @@ examples:
> >              reg = <0x69>;
> >              interrupt-parent = <&gpio6>;
> >              interrupts = <18 IRQ_TYPE_EDGE_RISING>;
> > +            mount-matrix = "0", "1", "0",
> > +                           "1", "0", "0",
> > +                           "0", "0", "1";
> >          };
> >      };
> >  ...
> > 
> > ---
> > base-commit: 591cd656a1bf5ea94a222af5ef2ee76df029c1d2
> > change-id: 20260414-bmg160-mount-matrix-dt-binding-e76ddde94866
> > 
> > Best regards,
> > --  
> > Vishwas Rajashekar <vishwas.dev@xxxxxxxxxxxxx>
> > 
> > 
> 

Regards,
Vishwas