Re: [PATCH v3] staging: octeon: remove SPI, POW, PKO, and Helper typedef enums

[Dan Carpenter]

On Fri, Apr 17, 2026 at 06:19:09PM -0500, Maxwell Doose wrote:
> This patch removes custom typedef enums and replaces them with standard
> enums to address the "General code review and cleanup" task in TODO.
> 
> The following enums are affected:
> 
> - cvmx_spi_mode_t (now enum cvmx_spi_mode)
> - cvmx_helper_interface_mode_t (now enum cvmx_helper_interface_mode_e)
> - cvmx_pow_wait_t (now enum cvmx_pow_wait)
> - cvmx_pko_lock_t (now enum cvmx_pko_lock)
> - cvmx_pko_status_t (now enum cvmx_pko_status)
> 
> This patch aligns the octeon codebase more closely with the Linux kernel
> code style, and will address the "cleanup" task in TODO.
> 
> Signed-off-by: Maxwell Doose <m32285159@xxxxxxxxx>
> ---
> v2:
>  - Appended "_e" to enum cvmx_helper_interface_mode to prevent namespace
>    collisions with a struct of the same name
>  - Fixed errors that were indirect results of the namespace collisions
> 
> v3:
>  - Fixed function return type in cvmx_helper_interface_get_mode

We're still not going to accept the _e on the end of
cvmx_helper_interface_mode_e.  Try figure out a better solution to
having two types with the same name.

regards,
dan carpenter