Re: [PATCH] staging: rtl8723bs: fix alignment issue in rtw_xmit.c

[Luka Gejak]

On April 18, 2026 9:37:32 AM GMT+02:00, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>On Sat, Apr 18, 2026 at 09:29:40AM +0200, Luka Gejak wrote:
>> On April 18, 2026 9:11:40 AM GMT+02:00, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>> >On Sat, Apr 18, 2026 at 08:57:08AM +0200, Luka Gejak wrote:
>> >> Hi Osdevhari,
>> >> Let's start from the top of the email. Firstly attachments are not 
>> >> allowed, only plaintext. Secondly Signed-off-by tag must use your real
>> >> name(Firstname Lastname <email>. Thirdly, you should setup git 
>> >> send-email and use it to send patches. One more thing why did you 
>> >> resend same email twice?
>> >> Best regards,
>> >> Luka Gejak
>> >
>> >Luka, please do not review patches like this, it is not the correct way.
>> >Please do so, by not using AI results, and doing so in the in-line
>> >fashion, like the style of what we do.
>> >
>> >And there is no requirement to use git send-email.
>> >
>> >Your email here alone has no context at all, making it impossible to
>> >properly quote or respond to.  Please don't do that.
>> >
>> >thanks,
>> >
>> >greg k-h
>> 
>> Hi Greg,
>> First of all it is not an ai response, and I didn't see need for 
>> quotes because I didn't actually talk about code but if prefer quotes 
>> at all times just let me know. And I suggested git send-email because 
>> it is easier for sending patches without worrying about plaintext or 
>> attachments. Also do you know how to get quotas from mailing list to 
>> my phone without manually copy pasting and adding >, since I am not by
>> my laptop right now and I don't know about something like lei for 
>> mobile. Also to clarify I used such tone becouse he is a begginer if 
>> that is what made you think this is ai review.
>
>Please do not us a phone email client that can not properly handle email
>quoting for reviewing new developer's patch submissions.  There is no
>rush here, nor need to confuse them with a style that is not the normal
>way of development we use at all.
>
It can do proper quoting but it takes a lot of time to copy it. If I 
was cced I would have no problem using quotes on my phone either. I 
use an app called acode in which I write emails(because of formating 
and line length) and then send it.
>
>And yes, the "tone" sounds like AI, please don't do that.
>
I understand and I won't do that anymore. I thought since he was a 
begginer it would be better use such tone instead of being bold for 
example as he would probably take it in differently.
Best regards,
Luka Gejak
>thanks,
>
>greg k-h