Re: [PATCH v2 1/2] x86/sev: Do not initialize SNP if missing CPUs

[Tom Lendacky]

On 4/8/26 08:10, Tom Lendacky wrote:
> On 4/7/26 12:47, Tycho Andersen wrote:
>> From: "Tycho Andersen (AMD)" <tycho@xxxxxxxxxx>
>>
>> The SEV firmware checks that the SNP enable bit is set on each CPU during
>> SNP initialization, and will fail if it is not. If there are some CPUs
>> offline, they will not run the setup functions, so SNP initialization will
>> always fail.
>>
>> Skip the IPIs in this case and return an error so that the CCP driver can
>> skip the SNP_INIT that will fail. Also print the CPU masks as a breadcrumb
>> so people can figure out what happened.
>>
>> Suggested-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>
>> Signed-off-by: Tycho Andersen (AMD) <tycho@xxxxxxxxxx>
>> ---

> 
> Reviewed-by: Tom Lendacky <thomas.lendacky@xxxxxxxxx>

Ugh, that's not the right email address:

Reviewed-by: Tom Lendacky <thomas.lendacky@xxxxxxx>

At least I spelled my name right...

> 
>> +	return ret;
>>  }
>>  EXPORT_SYMBOL_FOR_MODULES(snp_prepare, "ccp");
>>  
>