Re: [PATCH v2] ksmbd: Use AES-CMAC library for SMB3 signature calculation
From: Namjae Jeon
Date: Sun Apr 19 2026 - 04:16:52 EST
On Sun, Apr 19, 2026 at 7:18 AM Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
>
> Now that AES-CMAC has a library API, convert ksmbd_sign_smb3_pdu() to
> use it instead of a "cmac(aes)" crypto_shash.
>
> The result is simpler and faster code. With the library there's no need
> to dynamically allocate memory, no need to handle errors, and the
> AES-CMAC code is accessed directly without inefficient indirect calls
> and other unnecessary API overhead.
>
> Acked-by: Namjae Jeon <linkinjeon@xxxxxxxxxx>
> Reviewed-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
Applied it to #ksmbd-for-next-next.
Thanks!