Re: [PATCH sched_ext/for-7.1-fixes] tools/sched_ext: Add missing -d option in scx_flatcg
From: Cheng-Yang Chou
Date: Sun Apr 19 2026 - 12:08:43 EST
Hi Tejun,
On Sun, Apr 19, 2026 at 06:04:34AM -1000, Tejun Heo wrote:
> -d is dead code - it just sets dump_cgrps which is only echoed in the
> status-line printf, nothing actually dumps the cgroup hierarchy. The
> right thing to do is remove the whole thing - the 'd' in getopt(), case
> 'd':, the dump_cgrps variable and its printf - rather than document dead
> code as a feature.
>
> Want to spin a removal patch?
Yeah, for sure! Thanks for the explanation, will do!
--
Cheers,
Cheng-Yang