Re: [PATCH] pinctrl: mediatek: moore: implement gpio_chip::get_direction()

[Linus Walleij]

On Mon, Apr 13, 2026 at 6:59 PM Frank Wunderlich
<frank.wunderlich@xxxxxxxxx> wrote:
> Am 13. April 2026 um 10:01 schrieb "Linus Walleij" <linusw@xxxxxxxxxx mailto:linusw@xxxxxxxxxx?to=%22Linus%20Walleij%22%20%3Clinusw%40kernel.org%3E >:
> >
> > On Fri, Apr 10, 2026 at 11:24 AM Frank Wunderlich
> > <frank-w@xxxxxxxxxxxxxxx> wrote:
> >
> > >
> > > Gesendet: Freitag, 10. April 2026 um 09:09
> > >  Von: "Bartosz Golaszewski" <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > >  An: "Frank Wunderlich" <linux@xxxxxxxxx>, "Sean Wang" <sean.wang@xxxxxxxxxx>, "Linus Walleij" <linusw@xxxxxxxxxx>, "Matthias Brugger" <matthias.bgg@xxxxxxxxx>, "AngeloGioacchino Del Regno" <angelogioacchino.delregno@xxxxxxxxxxxxx>, "Bartosz Golaszewski" <brgl@xxxxxxxxxx>
> > >  CC: linux-mediatek@xxxxxxxxxxxxxxxxxxx, linux-gpio@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, "Bartosz Golaszewski" <bartosz.golaszewski@xxxxxxxxxxxxxxxx>
> > >  Betreff: [PATCH] pinctrl: mediatek: moore: implement gpio_chip::get_direction()
> > >
> > >  If the gpio_chip::get_direction() callback is not implemented by the GPIO
> > >  controller driver, GPIOLIB emits a warning.
> > >
> > >  Implement get_direction() for the GPIO part of pinctrl-moore.
> > >
> > >  Fixes: 471e998c0e31 ("gpiolib: remove redundant callback check")
> > >  Fixes: e623c4303ed1 ("gpiolib: sanitize the return value of gpio_chip::get_direction()")
> > >  Reported-by: Frank Wunderlich <linux@xxxxxxxxx>
> > >
> > >  please use the email i used for SoB in my linked patch (closes link below), the other email i use only for sending patches due to mail provider limitation.
> > >
> > I can't fix this up because the closes link isn't working right now.
> > Is it the same
> > as the one this mail came from frank-w@xxxxxxxxxxxxxxx?
>
> yes, closes-link works for me

Fixed up and applied. Will be going in as fix for v7.1.

Yours,
Linus Walleij