Re: [PATCH v2 4/4] arm64: dts: amlogic: t7: Add clk measure support

[Jian Hu]

Hi Ronald,


Thanks for your review.

On 4/17/2026 5:48 PM, Ronald Claveau wrote:
> [ EXTERNAL EMAIL ]
>
> Hello Jian,
>
> On 4/15/26 10:33 AM, Jian Hu via B4 Relay wrote:
> > From: Jian Hu <jian.hu@xxxxxxxxxxx>
> >
> > Add the clock measure device to the T7 SoC family.
> >
> > Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> > index 7fe72c94ed62..cec2ea74850d 100644
> > --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> > @@ -701,6 +701,11 @@ pwm_ao_cd: pwm@60000 {
> >                                status = "disabled";
> >                        };
> >
> > +                     clock-measurer@48000 {
> > +                             compatible = "amlogic,t7-clk-measure";
> > +                             reg = <0x0 0x48000 0x0 0x1c>;
> > +                     };
> > +
> Can you please order by reg, it should be between pwm_ao_gh and pwm_ab.
> Thank you.


According to the "Order of Nodes" chapter in 
Documentation/devicetree/bindings/dts-coding-style.rst,

nodes of the same type should be grouped together, and this takes higher 
priority.

So I have placed the clock-measure node after all PWM nodes to avoid 
splitting the PWM group.


Best regards,

Jian