Re: [PATCH v2] staging: media: atomisp: csi2: Fix DPCM decompression for source pad format
From: Andy Shevchenko
Date: Mon Apr 20 2026 - 02:47:30 EST
On Mon, Apr 20, 2026 at 7:35 AM Debjeet Banerjee
<debjeetbanerjee48@xxxxxxxxx> wrote:
>
> The CSI2 source pad format was set by blindly copying the sink pad
> format, regardless of whether the sink pad is receiving a DPCM-compressed
> mbus code. This was marked with a FIXME comment.
>
> When a sensor transmits DPCM-compressed data over MIPI CSI-2 (e.g.
> MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8), the Atom ISP hardware decompresses it
> before passing it to the ISP pipeline. Therefore the source pad must
> expose the uncompressed format (e.g. MEDIA_BUS_FMT_SGRBG10_1X10), not
> the compressed one.
>
> atomisp_subdev_uncompressed_code() already implements this mapping via
> the compressed_codes[] table in atomisp_subdev.c, which pairs each
> DPCM mbus code with its uncompressed counterpart. For codes that are not
> DPCM-compressed, the function returns the code unchanged, so this change
> is a no-op for all non-DPCM formats.
No, please spend your time first on learning the process. When sending
patches like this, do not rush with the new versions, keep at least
24h distance between them.
...
Also, drop the "staging:" prefix from the Subject.
--
With Best Regards,
Andy Shevchenko