Re: [PATCH 1/2] media: ipu-bridge: Add DMI information of Lenovo X9 to the image upside-down list

[Kate Hsuan]

Hi Hans,

On Fri, Apr 17, 2026 at 6:37 PM Hans de Goede
<johannes.goede@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Kate,
>
> On 17-Apr-26 10:32, Kate Hsuan wrote:
> > The Lenovo X9 has an upside-down-mounted Sony IMX471 sensor so the image
> > was displayed upside-down. Add the DMI information of Lenovo X9 to
> > resolve the issue.
> >
> > Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx>
> > ---
> >  drivers/media/pci/intel/ipu-bridge.c | 32 ++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> >
> > diff --git a/drivers/media/pci/intel/ipu-bridge.c b/drivers/media/pci/intel/ipu-bridge.c
> > index 32cc95a766b7..7b5b0dfc0190 100644
> > --- a/drivers/media/pci/intel/ipu-bridge.c
> > +++ b/drivers/media/pci/intel/ipu-bridge.c
> > @@ -118,6 +118,38 @@ static const struct dmi_system_id upside_down_sensor_dmi_ids[] = {
> >               },
> >               .driver_data = "OVTI02C1",
> >       },
> > +     {
> > +             /* Lenovo X9-14 */
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > +                     DMI_MATCH(DMI_BOARD_NAME, "21QA"),
> > +             },
> > +             .driver_data = "SONY471A",
> > +     },
> > +     {
> > +             /* Lenovo X9-14 */
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > +                     DMI_MATCH(DMI_BOARD_NAME, "21QB"),
> > +             },
> > +             .driver_data = "SONY471A",
> > +     },
>
> Can you try to instead match on the DMI_PRODUCT_VERSION ?
> that should contain "X9-14" or something like that,
> allowing you to use 1 entry instead of 2 .
>

Mark suggested me to match both types of X9 using DMI_BOARD_NAME.

The DMI_PRODUCT_VERSION is "ThinkPad X9-14 Gen1" and I think it can be
used to replace two entries.
I tested on X9-14 and it worked. I'll test it on X9-15 later. :)

>
> > +     {
> > +             /* Lenovo X9-15 */
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > +                     DMI_MATCH(DMI_BOARD_NAME, "21Q6"),
> > +             },
> > +             .driver_data = "SONY471A",
> > +     },
> > +     {
> > +             /* Lenovo X9-15 */
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> > +                     DMI_MATCH(DMI_BOARD_NAME, "21Q7"),
> > +             },
> > +             .driver_data = "SONY471A",
> > +     },
>
> Same here.
>
>
> >       {} /* Terminating entry */
> >  };
> >
>
> Regards,
>
> Hams
>


-- 
BR,
Kate