Re: [PATCH] iio: buffer: fix warning in requesting threaded irq
From: Andy Shevchenko
Date: Mon Apr 20 2026 - 05:22:16 EST
On Tue, Apr 21, 2026 at 09:52:52AM +0800, Junxiao Chang wrote:
> IRQF_ONESHOT is for threaded IRQ. If there is no threaded IRQ
> handler, this flag should not be set.
>
> This change fixes a warning during booting with kernel v7.0-rc3:
>
> WARNING: kernel/irq/manage.c:1502 at __setup_irq+0x1639/0x2510, CPU#3: iio-sensor-prox/974
> Call Trace:
> request_threaded_irq+0x2c7/0x490
> iio_trigger_attach_poll_func+0x353/0x6b0
> __iio_update_buffers+0x2420/0x2c70
> enable_store+0x183/0x270
> dev_attr_store+0x5e/0x90
> sysfs_kf_write+0x1e8/0x290
> kernfs_fop_write_iter+0x406/0x5f0
> vfs_write+0x71c/0xea0
These 3 lines do not bring much value.
> v3: remove unneeded log in git message
No, it's still there.
> v2: use ternary and drop temp variable
Also the changelog is still noise part of the commit message.
Whatever, I leave it to Jonathan who usually tweaks the patches whilst
applying.
...
What it worth is to add a summary of the driver (and platform, if available)
in use.
--
With Best Regards,
Andy Shevchenko