Re: [PATCH] dts: riscv: spacemit: k3: only keep spacemit,k1-i2c
From: Sandie Cao
Date: Mon Apr 20 2026 - 05:31:46 EST
Hi, Lan & Troy & Krzysztof :
> From: "Yixun Lan"<dlan@xxxxxxxxxx>
> Date: Mon, Apr 20, 2026, 17:09
> Hi Troy,
>
> On 16:50 Mon 20 Apr , Troy Mitchell wrote:
> > On Mon Apr 20, 2026 at 4:44 PM CST, Krzysztof Kozlowski wrote:
> > > On 20/04/2026 10:43, Krzysztof Kozlowski wrote:
> > >> On 20/04/2026 10:39, Sandie Cao wrote:
> > >>> Fix dtcheck issue: compatible:0: 'spacemit,k1-i2c' was expected
> > >>
> > >> Missing space after main commit msg.
> > >>
> > >>> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > >>> Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@xxxxxxxxx/
> > >>>
> > >
> > > Also, the file reported in above warning DOES NOT EXIST (I checked
> > > next-20260414).
> > In Documentation/devicetree/bindings/pinctrl/spacemit,k1-pinctrl.yaml:
> >
> > properties:
> > compatible:
> > enum:
> > - spacemit,k1-pinctrl
> > - spacemit,k3-pinctrl
> >
> I think you refer to wrong file, which should be
> Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
>
> > So there's no reason to use k1-i2c. As far as I can tell, while they are the same IP,
> > there are subtle differences between them.
> >
> But yes, the idea is correct, so NAK to this patch
> > - Troy
>
> --
> Yixun Lan (dlan)
>
Please know that, I send patch[1] to add DeepComputing FML13V05 board device tree. The patch is based on k1/dt-for-next[2].
And it meets dtscheck issue:
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Closes: https://lore.kernel.org/r/202604140259.eKDaxKua-lkp@xxxxxxxxx/
On k1/dt-for-next, it doesn't have spacemit,k3-i2c in Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml.
Or I use the wrong branch?
And what should I do for my patch[1] ?
[1] https://lore.kernel.org/all/20260413060524.1235982-1-sandie.cao@xxxxxxxxxxxxxxxx/
[2] https://github.com/spacemit-com/linux/tree/k1/for-next#
Best regards
Sandie