Re: [PATCH] media: venus: declare firmware files via MODULE_FIRMWARE

[Bryan O'Donoghue]

On 19/04/2026 23:39, Christopher Obbard wrote:
> The driver loads firmware blobs at runtime via request_firmware()
> but does not currently advertise the possible filenames. Add
> MODULE_FIRMWARE() entries for all known firmware variants so they are
> visible via modinfo and can be picked up by user space tooling.
>
> Signed-off-by: Christopher Obbard <christopher.obbard@xxxxxxxxxx>
> ---
>   drivers/media/platform/qcom/venus/core.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 7e639760c41d..7ed7cffb333b 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -1119,6 +1119,16 @@ static const struct venus_resources qcm2290_res = {
>   	.min_fw = &min_fw,
>   };
>
> +MODULE_FIRMWARE("qcom/venus-1.8/venus.mbn");
> +MODULE_FIRMWARE("qcom/venus-4.2/venus.mbn");
> +MODULE_FIRMWARE("qcom/venus-4.4/venus.mbn");
> +MODULE_FIRMWARE("qcom/venus-4.4/venus.mdt");
> +MODULE_FIRMWARE("qcom/venus-5.2/venus.mbn");
> +MODULE_FIRMWARE("qcom/venus-5.4/venus.mbn");
> +MODULE_FIRMWARE("qcom/vpu-1.0/venus.mbn");
> +MODULE_FIRMWARE("qcom/vpu-2.0/venus.mbn");
> +MODULE_FIRMWARE("qcom/venus-6.0/venus.mbn");
> +
>   static const struct of_device_id venus_dt_match[] = {
>   	{ .compatible = "qcom,msm8916-venus", .data = &msm8916_res, },
>   	{ .compatible = "qcom,msm8996-venus", .data = &msm8996_res, },
>
> ---
> base-commit: 4f5b4b748ac75683d61c304ee3ee0db235e8f312
> change-id: 20260419-wip-obbardc-qcom-venus-firmware-abdd35b05a22
>
> Best regards,
> --
> Christopher Obbard <christopher.obbard@xxxxxxxxxx>

What about the board dtsi files ?

#( 04/20/26@10:29 )( deckard@inspiron14p-linux 
):~/Development/linux@arm64-laptops-v7.1-rc6-camss✗✗✗
   grep -r "venus.mbn" *
arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi:	firmware-name 
= "qcom/sm8250/xiaomi/elish/venus.mbn";
arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts:	firmware-name = 
"qcom/qcm6490/fairphone5/venus.mbn";
arch/arm64/boot/dts/qcom/msm8996-xiaomi-gemini.dts:	firmware-name = 
"qcom/msm8996/gemini/venus.mbn";
arch/arm64/boot/dts/qcom/msm8996-oneplus3.dts:	firmware-name = 
"qcom/msm8996/oneplus3/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-sony-xperia-tama.dtsi:	firmware-name = 
"qcom/sdm845/Sony/tama/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-xiaomi-polaris.dts:	firmware-name = 
"qcom/sdm845/Xiaomi/polaris/venus.mbn";
arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi:	firmware-name = 
"qcom/sm8250/Sony/edo/venus.mbn";
arch/arm64/boot/dts/qcom/sm8250-xiaomi-pipa.dts:	firmware-name = 
"qcom/sm8250/xiaomi/pipa/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi:	firmware-name = 
"qcom/sdm845/OnePlus/enchilada/venus.mbn";
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-scorpio.dts:	firmware-name = 
"qcom/msm8996/scorpio/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-google-common.dtsi:	firmware-name = 
"qcom/sdm845/Google/blueline/venus.mbn";
arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts:	firmware-name = 
"qcom/qcm6490/SHIFT/otter/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts:	firmware-name = 
"qcom/sdm845/SHIFT/axolotl/venus.mbn";
arch/arm64/boot/dts/qcom/msm8996-oneplus3t.dts:	firmware-name = 
"qcom/msm8996/oneplus3t/venus.mbn";
arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi: 
firmware-name = "qcom/sdm845/Xiaomi/beryllium/venus.mbn";
arch/arm64/boot/dts/qcom/msm8996pro-xiaomi-natrium.dts:	firmware-name = 
"qcom/msm8996/natrium/venus.mbn";
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/venus-1.8/venus.mbn",
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/venus-4.2/venus.mbn",
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/venus-4.4/venus.mbn",
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/venus-5.2/venus.mbn",
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/venus-5.2/venus.mbn",
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/venus-5.4/venus.mbn",
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/vpu-1.0/venus.mbn",
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/vpu-2.0/venus.mbn",
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/vpu-2.0/venus.mbn",
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/venus-6.0/venus.mbn",
drivers/media/platform/qcom/venus/core.c:	.fwname = 
"qcom/vpu-2.0/venus.mbn",
drivers/media/platform/qcom/iris/iris_platform_gen1.c:	.fwname = 
"qcom/vpu-1.0/venus.mbn",

---
bod