Re: [PATCH v3 1/2] dt-bindings: input: Add PixArt PAJ7620 gesture sensor

[Krzysztof Kozlowski]

On Sat, Apr 18, 2026 at 02:22:32AM -0400, Harpreet Saini wrote:
> The binding include mandatory power supplies (vdd, vbus, vled)

Drop this part

> and optional GPIO controller properties to describe the hardware's
> ability to repurpose SPI pins opeating in I2C mode.

And just explain what is the purpose of GPIO controller - is this a GPIO
controller?

Plus language typo, run spell check.

> 
> Signed-off-by: Harpreet Saini <sainiharpreet29@xxxxxxxxx>
> ---
>  .../bindings/input/pixart,paj7620.yaml        | 79 +++++++++++++++++++
>  .../devicetree/bindings/vendor-prefixes.yaml  |  2 +
>  2 files changed, 81 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/pixart,paj7620.yaml
> 
> diff --git a/Documentation/devicetree/bindings/input/pixart,paj7620.yaml b/Documentation/devicetree/bindings/input/pixart,paj7620.yaml
> new file mode 100644
> index 000000000000..ad051cf641a6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/pixart,paj7620.yaml
> @@ -0,0 +1,79 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/pixart,paj7620.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: PixArt PAJ7620 Gesture Sensor
> +
> +maintainers:
> +  - Harpreet Saini <sainiharpreet29@xxxxxxxxx>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The PixArt PAJ7620 is a gesture recognition sensor with an integrated
> +  infrared LED and CMOS array. It communicates over an I2C interface and
> +  provides gesture data via a dedicated interrupt pin.
> +
> +properties:
> +  compatible:
> +    const: pixart,paj7620
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  vdd-supply:
> +    description: Main power supply.
> +
> +  vbus-supply:
> +    description: I/O and I2C bus power supply.
> +
> +  vled-supply:
> +    description: Power for the integrated IR LED.
> +
> +  linux,keycodes:
> +    minItems: 9
> +    maxItems: 9
> +    description: |

Do not need '|' unless you need to preserve formatting.

> +      List of keycodes mapping to the 9 supported gestures.
> +
> +  gpio-controller: true
> +
> +  "#gpio-cells":
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - vdd-supply
> +  - vbus-supply
> +  - vled-supply
> +

Missing allOf: with $ref to input.yaml schema. You use its properties.

Commit description said SPI, so missing ref to spi-peripheral-props.

> +additionalProperties: false

And this should be then unevaluatedProperties: false.

Best regards,
Krzysztof