Re: [PATCH v1] arm64: dts: qcom: qcs6490-rb3gen2: Add WCD headset playback and record for qcs6490-rb3gen2 industrial mezzanine

From: Krzysztof Kozlowski

Date: Mon Apr 20 2026 - 13:16:09 EST


On 18/04/2026 01:06, Dmitry Baryshkov wrote:
> On Fri, Apr 17, 2026 at 12:12:46PM +0200, Krzysztof Kozlowski wrote:
>> On 17/04/2026 11:42, Krzysztof Kozlowski wrote:
>>>
>>> And finally:
>>>
>>> Please run scripts/checkpatch.pl on the patches and fix reported
>>> warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
>>> patches and (probably) fix more warnings. Some warnings can be ignored,
>>> especially from --strict run, but the code here looks like it needs a
>>> fix. Feel free to get in touch if the warning is not clear.
>>
>> As you pointed correctly after offline talk, checkpatch does not report
>> undocumented compatible for the sound card qcs6490-rb3gen2-ia-snd-card.
>>
>> Unfortunately this patch did not go through internal toolset fully
>> (PatchWise), which could have flag the issue. Let's discuss it
>> internally next week.
>>
>>>
>>> Undocumented ABI (without any reference in changelog where to find
>>> posted patch).
>> You still need to solve the undocumented sound card ABI - new
>> compatible. If it is already sent to mailing lists, then provide link in
>> patch changelog (---).
>
> Which compatible is new there? I think it is a model and not compatible.

Ahh, damn, you are right. It's not adding any new compatible.

It's fine, I got confused, no new ABI here.

Thanks Dmitry, for pointing this out.

Best regards,
Krzysztof