Re: [PATCH 1/4] iio: magnetometer: ak8975: header cleanup

From: Andy Shevchenko

Date: Mon Apr 20 2026 - 14:35:32 EST


On Mon, Apr 20, 2026 at 11:08:01AM +0000, Joshua Crofts wrote:
> Clean up headers by removing proxy kernel.h header and adding new
> headers to ensure atomicity (array_size.h, dev_printk.h, types.h,
> asm/byteorder.h). Removed unused headers (slab.h, iio/sysfs.h,
> iio/trigger.h) and added minmax.h, property.h, wait.h, irqreturn.h to
> mitigate transient dependencies during compilation.
>
> Audited using the include-what-you-use tool.

Seems this implied sorting as well. As Jonathan says somewhere else
he prefers to split sorting and IWYU patches.

...

> #include <linux/iio/iio.h>
> -#include <linux/iio/sysfs.h>
> #include <linux/iio/buffer.h>
> -#include <linux/iio/trigger.h>
> #include <linux/iio/trigger_consumer.h>
> #include <linux/iio/triggered_buffer.h>

Also note that this group left unsorted.

>
> --
> 2.47.3
>

--
With Best Regards,
Andy Shevchenko