Re: [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite()

Next message: Chao Shi: "[PATCH v2 0/1] nvme: core: reject invalid LBA data size from Identify Namespace"
Previous message: David Carlier: "[PATCH] phy: apple: atc: Fix typec switch/mux leak and UAF on unbind"
In reply to: Robertus Diawan Chris: "[PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite()"
Next in thread: Luka Gejak: "Re: [PATCH] staging: rtl8723bs: remove unused offset in phase 2 _BlockWrite()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Ethan Tidmore

Date: Mon Apr 20 2026 - 19:16:35 EST

On Sun Apr 19, 2026 at 11:46 PM CDT, Robertus Diawan Chris wrote:
> Commit c1314fe4d28f ("staging: rtl8723bs: remove all RT_TRACE logs
> in hal/ and os_dep/") removed the unnecessary RT_TRACE logs in hal/
> and os_dep/ files, but left the variable "offset" in the Phase 2
> _BlockWrite() function unused, so delete it.
>
> This is reported by Coverity Scan with CID 1408950 as UNUSED_VALUE.
>
> Signed-off-by: Robertus Diawan Chris <robertusdchris@xxxxxxxxx>
> ---

LGTM.

Reviewed-by: Ethan Tidmore <ethantidmore06@xxxxxxxxx>

Thanks,

ET