Re: [PATCH v2] ASoC: dt-bindings: cdns: Convert xtfpga I2S to dt-schema
From: Krzysztof Kozlowski
Date: Tue Apr 21 2026 - 04:20:03 EST
On Fri, Apr 17, 2026 at 04:34:10PM +0530, Chaitanya Sabnis wrote:
> Convert the xtfpga I2S controller plain-text binding
> documentation to standard dt-schema (YAML).
Drop YAML references.
>
> The hardware requires exactly one memory region, one interrupt line,
> and one phandle to the master clock. Verified these constraints against
> the driver source in sound/soc/xtensa/xtfpga-i2s.c.
You changed the binding - added sound-dai-cells. This needs short
explanation in the commit msg.
>
> Reviewed-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
>
There is no blank line between tags. Please use b4 to collect tags.
> Signed-off-by: Chaitanya Sabnis <chaitanya.msabnis@xxxxxxxxx>
Subject - s/cdns/cdns,xtfpga-i2s/. And then drop redundant parts. You
are not changing here the cdns (cdns is a company), but a specific ONE
file.
Best regards,
Krzysztof