Re: [PATCH v2 16/53] selftests/mm: protection_keys: use kselftest framework
From: Mike Rapoport
Date: Tue Apr 21 2026 - 04:22:08 EST
On Mon, Apr 20, 2026 at 06:54:31PM +0100, Mark Brown wrote:
> On Sat, Apr 18, 2026 at 01:55:01PM +0300, Mike Rapoport wrote:
>
> > Adjust dprintf0() printouts to use "#" in the beginning of the line for
> > TAP compatibility and add fflush(stdout) in the end of the test to
> > ensure all the ksft_print_*() messages are really output.
>
> > + ksft_finished();
> > + fflush(stdout);
>
> If that fflush() is needed it should go into the helper, particularly
> since ksft_finshed() calls exit() so the fflush() will never be reachd.
Looks like I'm missing prints because of something in my environment, I'll
just drop the fflush().
--
Sincerely yours,
Mike.