Re: [PATCH v2 3/5] gpu: nova-core: do not import firmware commands into GSP command module
From: Eliot Courtney
Date: Tue Apr 21 2026 - 05:04:28 EST
On Tue Apr 21, 2026 at 3:16 PM JST, Alexandre Courbot wrote:
> Importing all the firmware commands like we did is a bit confusing, as
> the layer of a command type (fw or GSP) cannot be inferred from looking
> at its name alone. Furthermore it makes it impossible to create commands
> that have the same name as their firmware command.
>
> Thus, stop importing all commands and refer to them from the `fw` module
> instead.
>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---
Reviewed-by: Eliot Courtney <ecourtney@xxxxxxxxxx>