Re: [PATCH 2/2] media: i2c: imx471: Add Sony IMX471 image sensor driver

From: Sakari Ailus

Date: Tue Apr 21 2026 - 05:28:39 EST


Hi Serin,

On Mon, Apr 20, 2026 at 07:23:19AM +0000, Yeh, Serin wrote:
> There are some reasons that the upside-down mirror/flip functions can't
> be submitted in the driver for upstream.
>
> The version that I submitted for upstream is not included upside-down
> because the sensor has design limitations of mirror/flip.
>
> Your version will occur incorrect bayer older on different platform.

I believe we'll need the flipping controls as the sensor is mounted upside
down in some systems. The rotation is provided to the user space but it
remains up to the user space to configure the sensor accordingly.

If there's a need to adjust the digital crop rectangle, we'll probably need
the common raw sensor model patches for that. That's what the driver in
fact appears to be doing but I have to admit I didn't check that bit very
carefully.

--
Kind regards,

Sakari Ailus