Re: [net-next v2 3/5] dt-bindings: net: starfive,jh7110-dwmac: Add JHB100 sgmii rx clk

[Rob Herring]

On Mon, Apr 20, 2026 at 10:39 PM Minda Chen <minda.chen@xxxxxxxxxxxxxxxx> wrote:
>
>
>
>
> >
> > On Fri, Apr 17, 2026 at 10:45:21AM +0800, Minda Chen wrote:
> > > JHB100 SGMII interface tx/rx mac clock is split and require to set
> > > clock rate in 10M/100M/1000M speed. So dts need to add a new rx clock
> > > in code, dts and dt binding doc.
> > >
> > > Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx>
> > > ---
> > >  .../bindings/net/starfive,jh7110-dwmac.yaml   | 42 ++++++++++++++++---
> > >  1 file changed, 36 insertions(+), 6 deletions(-)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > > b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > > index edc246a71ce3..3802cdbf1848 100644
> > > --- a/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > > +++ b/Documentation/devicetree/bindings/net/starfive,jh7110-dwmac.yaml
> > > @@ -39,20 +39,26 @@ properties:
> > >      maxItems: 1
> > >
> > >    clocks:
> > > +    minItems: 5
> > >      items:
> > >        - description: GMAC main clock
> > >        - description: GMAC AHB clock
> > >        - description: PTP clock
> > >        - description: TX clock
> > >        - description: GTX clock
> > > +      - description: SGMII RX clock
> > >
> > >    clock-names:
> > > -    items:
> > > -      - const: stmmaceth
> > > -      - const: pclk
> > > -      - const: ptp_ref
> > > -      - const: tx
> > > -      - const: gtx
> > > +    minItems: 5
> > > +    maxItems: 6
> > > +    contains:
> > > +      enum:
> > > +       - stmmaceth
> > > +       - pclk
> > > +       - ptp_ref
> > > +       - tx
> > > +       - gtx
> > > +       - sgmii_rx
> >
> > No, this allows any of the above strings plus any other random strings.
> >
> > Rob
>
> Got it. Thanks. In JHB100 I will using "oneOf" 5 clocks or 6 clocks. 7100/7100 are const clock names

No, based on what you did for 'clocks', you just need:

  clock-names:
    minItems: 5
   items:
      - const: stmmaceth
      - const: pclk
      - const: ptp_ref
      - const: tx
      - const: gtx
      - sgmii_rx

Rob