Re: [PATCH v2 11/11] gpu: nova-core: vbios: reject extra PCI-AT and FWSEC images

From: Joel Fernandes

Date: Tue Apr 21 2026 - 12:16:34 EST




On 4/21/2026 12:01 PM, Timur Tabi wrote:
> On Tue, 2026-04-21 at 10:45 -0400, Joel Fernandes wrote:
>> My opinion is I don't see a benefit of changing it to that because
>> everything including Turing is working with current code.
>
> Well, we can't really say that, because we've only tested Nova on a handful of systems. Adding
> code that detects and reports unexpected variations is probably a really good idea at this
> stage.

I mean there are a lot of combinations of variations that are invalid, any
code change should be justified, not random. That said, as I mentioned I am
Ok either way if we want to check for this impossible condition.