Re: [PATCH] ASoC: qcom: x1e80100: limit speaker volumes

From: Mark Brown

Date: Tue Apr 21 2026 - 12:27:55 EST


On Tue, Apr 21, 2026 at 02:07:58PM +0200, Tobias Heider wrote:
> Limit the digital gain and PA volumes to a combined -3 dB in the machine
> driver to reduce the risk of speaker damage until we have active speaker
> protection in place (or higher safe levels have been established).

> + snd_soc_limit_volume(card, "WSA_RX0 Digital Volume", 81);
> + snd_soc_limit_volume(card, "WSA_RX1 Digital Volume", 81);

Do these actually match? The hamoa WSA devices look like they've got
sound-name-prefix specified so the actual controls will have WSA and
WSA2 prefixes but snd_soc_limit_volume() uses snd_soc_card_get_kcontrol()
which just does a snd_ctl_find_id_mixer(), that doesn't understand
prefixes.

Probably something in that chain of operations should log an error since
typos really aren't going to be discoverable here...

Attachment: signature.asc
Description: PGP signature