Re: [PATCH] ASoC: codecs: wcd937x: fix AUX PA sequencing and mixer controls
From: Mark Brown
Date: Tue Apr 21 2026 - 13:15:41 EST
On Mon, Apr 20, 2026 at 11:32:21PM +0530, Ajay Kumar Nandam wrote:
> Enable AUX PA sequencing during AUX DAC DAPM events and keep the
> AUX-specific RX supplies enabled while the path is active.
>
> Add the missing AUX-related mixer controls, including CLSH PA and
> DSD left/right switches, so AUX playback can be routed from userspace.
> @@ -730,10 +736,23 @@ static int wcd937x_codec_enable_aux_pa(struct snd_soc_dapm_widget *w,
> case SND_SOC_DAPM_PRE_PMD:
> disable_irq_nosync(wcd937x->aux_pdm_wd_int);
> + snd_soc_component_update_bits(component,
> + WCD937X_ANA_RX_SUPPLIES,
> + BIT(6), 0x00);
> + snd_soc_component_update_bits(component,
> + WCD937X_ANA_RX_SUPPLIES,
> + BIT(7), 0x00);
> break;
> case SND_SOC_DAPM_POST_PMD:
> usleep_range(2000, 2010);
It's a bit weird that the supplies are disabled in the _PRE_PMD
callback before DAPM disables the PGA, I'd have expected them after the
disable.
Attachment:
signature.asc
Description: PGP signature