Re: [PATCH] ASoC: amd: acp: Add DMI quirk for Valve Steam Deck OLED

From: Guilherme G. Piccoli

Date: Tue Apr 21 2026 - 16:27:26 EST



>> #define acp_get_drvdata(card) ((struct acp_card_drvdata *)(card)->drvdata)
>>
>> +/* List of DMI quirks - check acp-mach-common.c for usage. */
>> +#define TDM_MODE_ENABLE 1
>> +#define REMAP_DMIC_BT 2
>
> Since the list of quirks may grow over time, it might be worth differentiating
> these macros from the common ones — either by adding a `QUIRK_` prefix (or
> similar), or better yet, turning them into an enum?!
>
> Regardless,
>
> Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>

Hi Cristian! Thanks for the suggestion, I'm OK either way, let's see
what maintainers prefer and I can easily spin a V2 with such change.
Cheers,


Guilherme