Re: [PATCH v5] iio: buffer: fix warning in requesting threaded irq

[Andy Shevchenko]

On Thu, Apr 23, 2026 at 09:44:26AM +0800, Junxiao Chang wrote:
> IRQF_ONESHOT is for threaded IRQ. If there is no threaded IRQ
> handler, this flag should not be set.
> 
> This change fixes a warning during booting with kernel v7.0-rc3.
> Hardware: ARLs(Ultra 9 285) desktop
> Software: Ubuntu 24.04 + v7.0-rc3 kernel.
> 
> WARNING: kernel/irq/manage.c:1502 at __setup_irq+0x1639/0x2510, CPU#3: iio-sensor-prox/974
> Call Trace:
> request_threaded_irq+0x2c7/0x490
> iio_trigger_attach_poll_func+0x353/0x6b0
> __iio_update_buffers+0x2420/0x2c70
> enable_store+0x183/0x270
> dev_attr_store+0x5e/0x90
> 
> There is no threaded handler in thiggered buffer setup, e.g. vf610_adc

A typo here: triggered.

> and hid-sensor. They might introduce this warning.

But you see them IRL, right? Can you just add a point to the above list:

Hardware platform: ...
Hardware sensor in use: ... <— this to be added
Software stack (OS): ...

?

With that you may drop or rephrase that to

  "There is no threaded handler in triggered buffer setup in other drivers,
   e.g. vf610_adc and hid-sensor. They might introduce this warning."

> Signed-off-by: Junxiao Chang <junxiao.chang@xxxxxxxxx>
> ---

...

> V3/V4: https://lore.kernel.org/linux-iio/20260421103807.7ca935e9@jic23-huawei/T/#t

('T/#t' part is not needed)

> V2: https://lore.kernel.org/linux-iio/20260418002334.3643504-1-junxiao.chang@xxxxxxxxx/T/#mc0803722dce6585bbc8c9e0ec8289bd96afe99aa
> V1: https://lore.kernel.org/linux-iio/20260418002334.3643504-1-junxiao.chang@xxxxxxxxx/T/#mf0eba6c23049d15c2b43ea5528b5f5a47e216c58

Click there on the permalink to get the proper link to the mail, now it's an
indirect form of the links.

-- 
With Best Regards,
Andy Shevchenko