Re: [PATCH v2 3/3] pinctrl: qcom: lpass-lpi: Resume clocks for GPIO access

From: Konrad Dybcio

Date: Wed Apr 22 2026 - 07:02:58 EST


On 4/20/26 2:31 PM, Ajay Kumar Nandam wrote:
> Ensure the LPI pinctrl device clocks are runtime resumed
> before accessing GPIO registers and autosuspended after
> the access completes.
>
> Guard GPIO register read and write helpers with synchronous
> runtime PM calls so the device is active during MMIO
> operations.
>
> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@xxxxxxxxxxxxxxxx>
> ---

Lacking this patch with the previous one in place also seems like
it could cause crashes, since the resources are not enabled.

I think it should be fine to have a patch adding .pm ops first
(which if I read things correctly should be a NOP so long as you
don't call xyz_runtime_pm_abc() functions) and then the remaining
parts of patches 1 and 3 could be squashed together as a second
change

Konrad