Re: [PATCH] pinctrl: renesas: rzg2l: Fix incorrect PUPD register offset for high pins during suspend/resume

[Geert Uytterhoeven]

On Sat, 28 Mar 2026 at 10:05, Biju <biju.das.au@xxxxxxxxx> wrote:
> From: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> When saving/restoring pull-up/down register state during suspend/resume,
> the second PUPD register access was incorrectly using the same base offset
> as the first, effectively reading/writing the same register twice instead
> of the adjacent one.
>
> Add the correct + 4 byte offset to the second RZG2L_PCTRL_REG_ACCESS32
> call so that pupd[1][port] is properly saved and restored from the next
> 32-bit register in the PUPD register pair, covering pins 4–7 of ports
> with 4 or more pins.
>
> Fixes: b2bd65fbb617 ("pinctrl: renesas: rzg2l: Add suspend/resume support for pull up/down")
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-pinctrl-fixes for v7.1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds