Re: [PATCH] dcache: add extra sanity checks of the dentry in dentry_free()

From: Jeff Layton

Date: Wed Apr 22 2026 - 09:56:52 EST


On Wed, 2026-04-22 at 15:16 +0200, Jori Koolstra wrote:
> On Wed, Apr 22, 2026 at 07:29:48AM -0400, Jeff Layton wrote:
> >
> > +#define DENTRY_WARN_ONCE(condition, dentry) \
> > + WARN_ONCE((condition), "dentry=%p d_flags=0x%x\n", (dentry), (dentry)->d_flags)
> >
>
> I guess this is one of those instances where using %p is acceptable?
> Maybe Documentation/process/deprecated.rst is worded a bit too harshly.

I'm not opposed to using something different, but I think the hashed
pointer value is fine here. Mostly I just want some way to tell whether
different warnings might have been triggered by the same dentry.
--
Jeff Layton <jlayton@xxxxxxxxxx>