Re: [RFC] [QUESTION] Stuff to do for string
From: Josh Law
Date: Wed Apr 22 2026 - 12:57:08 EST
On 22 April 2026 17:51:40 BST, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxx> wrote:
>On Wed, Apr 22, 2026 at 05:28:39PM +0100, Josh Law wrote:
>> On 22 April 2026 17:12:37 BST, Andy Shevchenko
>> <andriy.shevchenko@xxxxxxxxx> wrote:
>> >On Wed, Apr 22, 2026 at 03:57:16PM +0100, Josh Law wrote:
>> >> Hello, (this is my first RFC, so maybe cc is bad, but yeah)
>> >>
>> >> What do you guys have planned/would like me to have a look at doing
>in
>> >> lib/string.c
>> >>
>> >> I am home from school so I am virtually free
>> >
>> >Arbitrary things that came to my mind (no particular order)
>> >
>> >- Get rid of strlcat()
>>
>> Yeah, I'm working on that actually :D, privately, I sorta stopped cuz i
>> thought kees was gonna do that, if not, not issue!
>>
>> >- Clean up include/linux/string.h
>> > a) drop extern for functions
>> > b) put the headers it includes into an order and follow IWYU
>>
>> Hmm, yeah, I see it's kind of a mess (in a polite way)
>>
>> >- kill memscan() in favour of memchr() / memchr_inv()
>>
>> Hmm, maybe, is there a crazy amount of files that call memscan()?
>
>You can find an answer yourself. The daily-basis kill feature tool is
>`git grep ...`.
Oh, yes, I see this now, I should be able to do this, gotta slap the
computer awake cuz sometimes it breaks. So it may take time for me
to submit it, would you like a treewide cleanup, or subsystem by subsystem
Thanks!
>> I'll also (try ;), yk, school :( ) to review patches for your file. Ig
>> it's the best I do for you lot right now, (I am starting to review most
>> if not all patches in lib), e.g:
>>
>https://lore.kernel.org/all/AA9B2A7E-A88D-457C-8244-50087631B347@xxxxxxxxx
>> :)
>
>