Re: [PATCH v1] drm/panel: lg-sw43408: remove panel on DSI attach failure

[Dmitry Baryshkov]

On Mon, Apr 20, 2026 at 04:38:27PM +0900, Myeonghun Pak wrote:
> The probe path registers the panel by calling drm_panel_add() in
> sw43408_add(), then returns the result of mipi_dsi_attach() directly
> from sw43408_probe().
> 
> If mipi_dsi_attach() fails, the probe path exits without calling
> drm_panel_remove(), leaving the panel registered in the global DRM
> panel list. The .remove() callback does not cover this case because
> it is only invoked after a successful probe.
> 
> Fix this by unwinding the panel registration with drm_panel_remove()
> when mipi_dsi_attach() fails.
> 
> Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> Co-developed-by: Taegyu Kim <tmk5904@xxxxxxx>
> Signed-off-by: Taegyu Kim <tmk5904@xxxxxxx>
> Co-developed-by: Yuho Choi <dbgh9129@xxxxxxxxx>
> Signed-off-by: Yuho Choi <dbgh9129@xxxxxxxxx>
> Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-lg-sw43408.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 

You can also switch to devm_drm_panel_add().

-- 
With best wishes
Dmitry