Re: [PATCH 2/2] hwmon: (pmbus/lx1308) Add support for LX1308

[Krzysztof Kozlowski]

On Wed, Apr 22, 2026 at 12:06:16PM +0000, Brian Chiang wrote:
> +
> +static struct pmbus_driver_info lx1308_info = {
> +	.pages = 1,
> +	.format[PSC_VOLTAGE_IN] = linear,
> +	.format[PSC_VOLTAGE_OUT] = linear,
> +	.format[PSC_CURRENT_IN] = linear,
> +	.format[PSC_CURRENT_OUT] = linear,
> +	.format[PSC_POWER] = linear,
> +	.format[PSC_TEMPERATURE] = linear,
> +
> +	.func[0] = PMBUS_HAVE_VIN | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT
> +		| PMBUS_HAVE_IIN | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT
> +		| PMBUS_HAVE_PIN | PMBUS_HAVE_POUT
> +		| PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP
> +		| PMBUS_HAVE_STATUS_INPUT,
> +
> +	.read_word_data  = lx1308_read_word_data,
> +	.write_word_data = lx1308_write_word_data,
> +};
> +
> +static const struct i2c_device_id lx1308_id[] = {
> +	{ "lx1308" },
> +	{ }
> +};

All ID tables should be next to each other, usually just before the
struct with driver.

> +
> +MODULE_DEVICE_TABLE(i2c, lx1308_id);
> +

...

> +	if (ret != 12 || buf[0] != 'V')
> +		return dev_err_probe(&client->dev, -ENODEV,
> +				     "Unsupported Manufacturer Revision '%s'\n", buf);
> +	return pmbus_do_probe(client, &lx1308_info);
> +}
> +
> +static const struct of_device_id lx1308_of_match[] = {
> +	{ .compatible = "luxshare,lx1308" },

Where is the rest of your compatibles? Do not document ABI which is
unused. submitting-patches in DT forbids that.

> +	{ }
> +};
> +
> +MODULE_DEVICE_TABLE(of, lx1308_of_match);

Best regards,
Krzysztof