Re: [PATCH v10 1/4] ASoC: SDCA: Add PDE state transition helper

[Charles Keepax]

On Wed, Apr 22, 2026 at 07:56:09PM +0200, Pierre-Louis Bossart wrote:
> On 4/22/26 10:26, Charles Keepax wrote:
> > On Tue, Apr 21, 2026 at 06:21:09PM +0200, Pierre-Louis Bossart wrote:
> >> On 4/21/26 17:57, Charles Keepax wrote:
> >>> On Tue, Apr 21, 2026 at 09:18:01PM +0530, Niranjan H Y wrote:
> > That is what is happening in the above code setting the
> > reg/mask/on_val/off_val, DAPM uses that information to do the
> > register write.
> 
> Since we have two different ways of doing this PDE management,
>do we need two helpers, one with the write and one without?

I would really vote for just the polling helper, most of the time
the register should be written by DAPM and for drivers that don't
those drivers will likely be writing a bunch of other registers in
the event handler anyway so what is one more.

Thanks,
Charles