Re: [PATCH] perf dwarf-regs: Fix off by one in __get_dwarf_regnum_for_perf_regnum_csky()

[James Clark]

On 23/04/2026 08:00, Dan Carpenter wrote:
> Change the > comparison >= to prevent an out of bounds access of
> the dwarf_csky_regnumsp[] array.
>
> Fixes: 8cac4013b0c2 ("perf dwarf-regs: Add csky perf to dwarf register number mapping functions")
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> ---
> ---
>   tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c b/tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c
> index cb44b774f8d9..4c586a5cb763 100644
> --- a/tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c
> +++ b/tools/perf/util/dwarf-regs-arch/dwarf-regs-csky.c
> @@ -118,7 +118,7 @@ int __get_dwarf_regnum_for_perf_regnum_csky(int perf_regnum, unsigned int flags)
>   	if (flags & EF_CSKY_ABIV2)
>   		idx++;
>   
> -	if (perf_regnum <  0 || perf_regnum > (int)ARRAY_SIZE(dwarf_csky_regnums) ||
> +	if (perf_regnum <  0 || perf_regnum >= (int)ARRAY_SIZE(dwarf_csky_regnums) ||
>   	    dwarf_csky_regnums[perf_regnum][idx] == 0)
>   		return -ENOENT;
>   

Reviewed-by: James Clark <james.clark@xxxxxxxxxx>