Re: [PATCH v2 net 0/11] octeontx2-af: npc: cn20k: MCAM fixes

[Paolo Abeni]

On 4/20/26 4:34 AM, Ratheesh Kannoth wrote:
> This series tightens Marvell OcteonTX2 AF NPC support for CN20K
> silicon around MCAM key typing, optional debugfs setup, defrag
> allocation rollback, x2 versus x4 KEX profiles and default-rule
> allocation, logical MCAM clear and configuration, default-rule index
> bookkeeping and explicit teardown, and NIXLF reserved-slot lookup when
> default rules are missing.
> 
> Patches 1 through 3 focus on AF error handling: propagate
> npc_mcam_idx_2_key_type() failures through cn20k MCAM enable, config,
> copy, and read paths; treat cn20k NPC debugfs files as optional so
> probe does not fail when debugfs is unavailable; and fix defrag MCAM
> allocation rollback so allocation errno is not overwritten by subbank
> index resolution.
> 
> Patches 4 and 5 align default-rule and flow-install behaviour with the
> loaded mkex profile: prefer x4 default entries when the profile is x4,
> and reject x4 flow keys when the profile is strictly x2.
> 
> Patches 6 through 8 refine cn20k MCAM programming: clear entries by
> logical index and resolved key width, fix bank and CFG sequencing in
> npc_cn20k_config_mcam_entry(), and read action metadata from the
> correct bank in npc_cn20k_read_mcam_entry().
> 
> Patches 9 through 11 complete default-rule lifecycle handling:
> initialize all default-rule index outputs up front, tear down default
> MCAM rules explicitly (coordinated with npc_mcam_free_all_entries()),
> and reject USHRT_MAX sentinel indices in npc_get_nixlf_mcam_index()
> for cn20k.
> 
> Ratheesh Kannoth (11):
>   octeontx2-af: npc: cn20k: Propagate MCAM key-type errors on cn20k
>   octeontx2-af: npc: cn20k: Drop debugfs_create_file() error checks in
>   init
>   octeontx2-af: npc: cn20k: Propagate errors in defrag MCAM alloc
>   rollback
>   octeontx2-af: npc: cn20k: Make default entries as x4.
>   octeontx2-af: npc: cn20k: Reject request for x4 entries in x2
>   profile.
>   octeontx2-af: npc: cn20k: Clear MCAM entries by index and key width
>   octeontx2-af: npc: cn20k: Fix bank value.
>   octeontx2-af: npc: cn20k: Fix MCAM actions read
>   octeontx2-af: npc: cn20k: Initialize default-rule index outputs up
>   front
>   octeontx2-af: npc: cn20k: Tear down default MCAM rules explicitly on
>   free
>   octeontx2-af: npc: cn20k: Reject missing default-rule MCAM indices
> 
> Signed-off-by: Ratheesh Kannoth <rkannoth@xxxxxxxxxxx>
> 
> --
> v1 -> v2: Addressed simon comments. Added more patch fixes to this series.
> 	https://lore.kernel.org/netdev/20260418162013.GG280379@xxxxxxxxxxxxxxxx/

I strongly suggest avoid extending a series to address issues found by
the AI review, unless such issues are actual regressions/problems
introduced by the new code. Sashiko tends to find a lot of collateral
problem and the series could easily expand beyond any hope of merging.

Instead you should reply on the ML, commenting on sashiko's review,
explain why or why not the outlined problems are valid and/or should be
handled separately.

Thanks,

Paolo