Re: [RFC 2/4] tpm_crb: Add new wrapper function to invoke start method

[Arun Menon]

On Wed, Apr 08, 2026 at 11:36:06AM +0300, Jarkko Sakkinen wrote:
> On Tue, Mar 24, 2026 at 06:13:20PM +0530, Arun Menon wrote:
> > 
> > On Tue, Mar 24, 2026 at 12:42:19PM +0200, Jarkko Sakkinen wrote:
> > > On Tue, Mar 24, 2026 at 12:48:01PM +0530, Arun Menon wrote:
> > > > - Extract start invocation code into a separate function called
> > > >   crb_trigger_tpm. This will be helpful in repeatedly calling the
> > > >   start method with different bits set to toggle between start,
> > > >   nextChunk or crbRspRetry behaviours.
> > > > - Based on the bit set, we signal the TPM to consume
> > > >   contents of the command/response buffer.
> > > > - No functional change intended.
> > > 
> > > Please write a proper commit message, which is not a task list.
> > 
> > Yes, I shall do that. Thank you for taking a look.
> 
> Yeah, and now is good time to improve cosmetic details like this.
> 
> I rather take closer look at code when I can run it as I'm not LLM
> coding agent, I need to run to understand cannot hallucinate it :-)

Makes total sense. I have updated the commit messages in v2.
https://lore.kernel.org/lkml/20260324181244.17741-2-armenon@xxxxxxxxxx/

> 
> BR, Jarkko

Regards,
Arun Menon