Re: [PATCH] dt-bindings: qcom: geni-se-qup: Add compatible for Nord SoC

From: Shawn Guo

Date: Thu Apr 23 2026 - 07:07:18 EST


On Mon, Apr 20, 2026 at 02:44:01PM +0800, Shawn Guo wrote:
> From: Deepti Jaggi <deepti.jaggi@xxxxxxxxxxxxxxxx>
>
> Add compatibles for GENI Serial Engine QUP Wrapper Controller on Nord SoC
> with fallback on SA8255P compatibles.
>
> Signed-off-by: Deepti Jaggi <deepti.jaggi@xxxxxxxxxxxxxxxx>
> Signed-off-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> ---
> .../soc/qcom/qcom,sa8255p-geni-se-qup.yaml | 20 +++++++++++++++----
> 1 file changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,sa8255p-geni-se-qup.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,sa8255p-geni-se-qup.yaml
> index 352af3426d34..d73f9edcbbdb 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,sa8255p-geni-se-qup.yaml
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,sa8255p-geni-se-qup.yaml
> @@ -19,7 +19,12 @@ description:
>
> properties:
> compatible:
> - const: qcom,sa8255p-geni-se-qup
> + oneOf:
> + - enum:
> + - qcom,sa8255p-geni-se-qup
> + - items:
> + - const: qcom,nord-auto-geni-se-qup

AUTO variant of Nord is SA8797P, so it makes more sense to use
'qcom,sa8797p-geni-se-qup' which is more consistent to
'qcom,sa8255p-geni-se-qup'. Will update in the next version.

Shawn

> + - const: qcom,sa8255p-geni-se-qup
>
> reg:
> description: QUP wrapper common register address and length.
> @@ -67,9 +72,16 @@ patternProperties:
>
> properties:
> compatible:
> - enum:
> - - qcom,sa8255p-geni-uart
> - - qcom,sa8255p-geni-debug-uart
> + oneOf:
> + - enum:
> + - qcom,sa8255p-geni-uart
> + - qcom,sa8255p-geni-debug-uart
> + - items:
> + - const: qcom,nord-auto-geni-uart
> + - const: qcom,sa8255p-geni-uart
> + - items:
> + - const: qcom,nord-auto-geni-debug-uart
> + - const: qcom,sa8255p-geni-debug-uart
>
> required:
> - compatible
> --
> 2.43.0
>