Re: [PATCH v4 2/2] arch: arm64: boot: dts: qcom: add IMEM and PIL regions for glymur

[Ananthu C V]

On Wed, Apr 22, 2026 at 01:07:46PM +0200, Konrad Dybcio wrote:
> On 4/21/26 11:47 AM, Ananthu C V wrote:
> > Hi Konrad,
> > 
> > On Wed, Apr 08, 2026 at 11:42:14AM +0200, Konrad Dybcio wrote:
> >> On 3/27/26 11:24 AM, Ananthu C V wrote:
> >>> Add an IMEM on glymur which falls back to mmio-sram and define the
> >>> PIL relocation info region as its child, for post mortem tools to
> >>> locate the loaded remoteprocs.
> >>>
> >>> Signed-off-by: Ananthu C V <ananthu.cv@xxxxxxxxxxxxxxxx>
> >>> ---
> >>>  arch/arm64/boot/dts/qcom/glymur.dtsi | 16 ++++++++++++++++
> >>>  1 file changed, 16 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> >>> index 4886e87ebd49..21ae05f0ee17 100644
> >>> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> >>> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
> >>> @@ -6457,6 +6457,22 @@ rx-pins {
> >>>  			};
> >>>  		};
> >>>  
> >>> +		sram@14680000 {
> >>> +			compatible = "qcom,glymur-imem", "mmio-sram";
> >>> +			reg = <0x0 0x14680000 0x0 0x1000>;
> >>> +			ranges = <0 0 0x14680000 0x1000>;
> >>
> >> size=0x2c_000
> > 
> > on glymur the imem region is a 4kb region of size 0x1000.
> 
> No.. that's the "shared" slice of it

Indeed, I missed out on mentioning the "shared" word. The size of the whole
imem region is indeed 0x2c_000. I used kaanapali, which only mentions the
shared imem region, as a reference before. I'll make a revision to reflect
the whole imem region size. Thanks for the review.

Best,
Ananthu