Re: [PATCH 6.1.y] drm/amdgpu: remove two invalid BUG_ON()s

[Timur Kristóf]

On Thursday, April 23, 2026 1:22:22 PM Central European Summer Time Greg 
Kroah-Hartman wrote:
> On Wed, Apr 22, 2026 at 04:11:15PM +0200, Christian König wrote:
> > Those points are certainly valid.
> > 
> > I've also up-streamed a patch which completely rejects userspace
> > submissions who try to use the CE.
> > 
> > The problem is that those BUG_ON() can lead to a deny of service because
> > they crash the whole kernel.
> > 
> > A BUG_ON() is only justified if it prevents even worse things to happen,
> > e.g. data corruption or it would crash later on anyway just not so
> > obvious on what is wrong.
> > 
> > Otherwise we should use WARN_ON().
> 
> WARN_ON() crashes the kernel as well when panic-on-warn is enabled, as
> it is in a few billion Linux systems :(
> 
> As this commit is upstream, and in other stable trees, I'll apply this
> as it's not nice to have a simple way for userspace to crash the system.
> 
> thanks,
> 
> greg k-h

Sounds reasonable, if you feel this improves stability.

That being said, there are many other ways besides this one for userspace to 
crash the system equally easily.

Timur