Re: [PATCH v3 4/4] arm64: dts: qcom: sdm630: assign adsp_mem region to ADSP FastRPC node

[Konrad Dybcio]

On 4/23/26 3:06 PM, Nickolay Goppen wrote:
> 
> 23.04.2026 14:05, Konrad Dybcio пишет:
>> On 4/22/26 5:39 PM, Nickolay Goppen wrote:
>>> Downstream [1] ADSP FastRPC node has the adsp_mem region assigned, so
>>> assign it to the ADSP FastRPC node.
>>>
>>> [1]: https://github.com/xiaomi-sdm660/android_kernel_xiaomi_sdm660/blob/11-EAS/arch/arm/boot/dts/qcom/sdm660.dtsi#L1693
>>>
>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
>>> Signed-off-by: Nickolay Goppen <setotau@xxxxxxxxxxxxxx>
>>> ---
>>>   arch/arm64/boot/dts/qcom/sdm630.dtsi | 3 +++
>>>   1 file changed, 3 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
>>> index 36b419dea153..af2bc29ccdad 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
>>> @@ -2458,6 +2458,9 @@ fastrpc {
>>>                       compatible = "qcom,fastrpc";
>>>                       qcom,glink-channels = "fastrpcglink-apps-dsp";
>>>                       label = "adsp";
>>> +                    memory-region = <&adsp_mem>;
>>> +                    qcom,vmids = <QCOM_SCM_VMID_LPASS
>>> +                              QCOM_SCM_VMID_ADSP_HEAP>;
>> Please double-check that, the VMID used to be different on
>> older SoCs
> Do you know how to check that?

The least painful way is probably to add debug prints to what downstream
calls hyp_assign_phys()

Konrad