Re: [PATCH v4 2/3] mm/swap: use swap_ops to register swap device's methods

[Chris Li]

The incremental change code logic looks fine.

On Wed, Apr 22, 2026 at 7:37 PM Baoquan He <baoquan.he@xxxxxxxxx> wrote:
>
> diff --git a/mm/swapfile.c b/mm/swapfile.c
> index af81fa212f1e..7644049a0919 100644
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -3518,10 +3518,8 @@ SYSCALL_DEFINE2(swapon, const char __user *, specialfile, int, swap_flags)
>                 goto bad_swap_unlock_inode;
>         }
>
> -       if (init_swap_ops(si)) {
> -               error = -EINVAL;
> +       if (error = init_swap_ops(si))

Some more nitpicks:

I think some compiler option might warn about assigning a variable
inside an if condition. I suggest moving the assignment outside of the
if condition expression. As it is, it looks very close to "error ==
init_swap_ops(si))", Some compiler might warn, "Is that what you mean
instead?"

Chris

>                 goto bad_swap_unlock_inode;
> -       }

>
>         si->max = maxpages;
>         si->pages = maxpages - 1;
>