Re: [PATCH v2 6/8] ALSA: hda: Add support for Hygon family 18h model 5h HD-Audio

[Fu Hao]

On 2026/4/11 6:47, Bjorn Helgaas wrote:
> On Tue, Apr 07, 2026 at 04:24:56PM +0800, Fu Hao wrote:
> > Add the new PCI ID 0x1d94 0x14a9 for Hygon family 18h model 5h
> > HDA controller.
> >
> > Signed-off-by: Fu Hao <fuhao@xxxxxxxxxxxxxx>
> > ---
> >   include/linux/pci_ids.h       | 1 +
> >   sound/hda/controllers/intel.c | 5 +++++
> >   2 files changed, 6 insertions(+)
> >
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index 406abf629..19d968017 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2613,6 +2613,7 @@
> >   #define PCI_VENDOR_ID_ROCKCHIP		0x1d87
> >   
> >   #define PCI_VENDOR_ID_HYGON		0x1d94
> > +#define PCI_DEVICE_ID_HYGON_18H_M05H_HDA	0x14a9
>
> It looks like PCI_DEVICE_ID_HYGON_18H_M05H_HDA is only used in
> sound/hda/controllers/intel.c, so it should probably be defined there
> so you don't need to modify include/linux/pci_ids.h:
>
>   *      Do not add new entries to this file unless the definitions
>   *      are shared between multiple drivers.

Thank you for the clear guidance.I will modify it in v3 patch.

--
Regards,
Fu Hao