Re: [PATCH v4] ACPI: pmic: Replace mutex_lock/unlock() with guard()/scoped_guard()

[Andy Shevchenko]

On Wed, Apr 29, 2026 at 4:14 PM Maxwell Doose <m32285159@xxxxxxxxx> wrote:
> On Wed, Apr 29, 2026 at 4:55 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxx> wrote:
> > On Tue, Apr 28, 2026 at 08:24:32PM -0500, Maxwell Doose wrote:

...

> > It should be
> >
> >         int ret; // also left untouched, drop that from commit message as well

> >         if (d->exec_mipi_pmic_seq_element) {

I realised that the body below should be...

> >                 // the below if-else-if just should be left untouched.
> >                 if (i2c_address == d->pmic_i2c_address) {
> >                         ...
> >                 } else {
> >                         ...
> >                 }
> >
> >                 return ret;
> >         }
> >
> >         if (d->pmic_i2c_address) {

...part of this conditional. But I hope you got the idea.

> >         }
> >
> >         ...warnings...
> >         return -EOPNOTSUPP;
>
> Alright, thanks for clarifying this. I'll make sure this gets in for the v4.

-- 
With Best Regards,
Andy Shevchenko