Re: [PATCH net-next] net: gianfar: use alloc_ethdev_mqs
From: Andrew Lunn
Date: Wed Apr 29 2026 - 09:32:21 EST
> I see what you mean. Will respin this.
This is why the netdev FAQ says:
Netdev discourages patches which perform simple clean-ups, which are
not in the context of other work.
...
This is because it is felt that the churn that such changes produce
comes at a greater cost than the value of such clean-ups.
Does changing alloc_netdev_mq() to alloc_netdev_mqs() bring enough
gain to offset the work needed to find the new bugs added at the same
time?
I know i would prefer looking at patches adding new drivers, new
infrastructure, new features, than broken cleanups for very old
drivers with very few users.
Andrew