Re: [PATCH v3 1/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in i2c probe

[Osama Abdelkader]

Hi Luca,

On Wed, Apr 29, 2026 at 01:40:39PM +0200, Luca Ceresoli wrote:
> On Thu Apr 23, 2026 at 10:05 PM CEST, Osama Abdelkader wrote:
> > Use devm_drm_bridge_add() so the bridge is released if probe fails after
> > registration, and drop drm_bridge_remove() in chipone_i2c_probe.
> >
> > Signed-off-by: Osama Abdelkader <osama.abdelkader@xxxxxxxxx>
> > Fixes: 8dde6f7452a1 ("drm: bridge: icn6211: Add I2C configuration support")
> > Cc: stable@xxxxxxxxxxxxxxx
> > ---
> > v3: split the patch into two, one for i2c probe (bugfix) and one for dsi probe,
> >     and add Fixes and Cc tags
> > v2: devm_drm_bridge_add instead of drm_bridge_add
> > ---
> >
> >  drivers/gpu/drm/bridge/chipone-icn6211.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c
> > index 5bee10c64265..4d76e1bd5e78 100644
> > --- a/drivers/gpu/drm/bridge/chipone-icn6211.c
> > +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c
> > @@ -758,12 +758,12 @@ static int chipone_i2c_probe(struct i2c_client *client)
> >  	dev_set_drvdata(dev, icn);
> >  	i2c_set_clientdata(client, icn);
> >
> > -	drm_bridge_add(&icn->bridge);
> > -
> > -	ret = chipone_dsi_host_attach(icn);
> > +	ret = devm_drm_bridge_add(dev, &icn->bridge);
> >  	if (ret)
> > -		drm_bridge_remove(&icn->bridge);
> > -	return ret;
> > +		return ret;
> > +
> > +	return chipone_dsi_host_attach(icn);
> > +
> >  }
> >
> >  static void chipone_dsi_remove(struct mipi_dsi_device *dsi)
> 
> This patch does not apply. Is it messed up with patch 2/2?
> 

The file was changed on upstream in the meanwhile, so I refreshed my patch.

> Luca
> 
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com