Re: [PATCH v3 2/2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add in dsi probe

[Osama Abdelkader]

Hello Luca,

On Thu, Apr 30, 2026 at 01:01:16PM +0200, Luca Ceresoli wrote:
> Hello Osama,
> 
> On Thu Apr 23, 2026 at 10:06 PM CEST, Osama Abdelkader wrote:
> > Use devm_drm_bridge_add() so the bridge is released if probe fails after
> > registration, and drop drm_bridge_remove() in chipone_dsi_probe.
> 
> Wait, this patch must drop drm_bridge_remove() in chipone_dsi_remove() too!
> Otherwise it'd be introducing an excess put, and consequent use-after-free.
> 
> I have to withdraw my R-by.
> 
> You can amend in v4.
> 

Good catch, added now in v4.

Thanks,
Osama

> Luca
> 
> --
> Luca Ceresoli, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com