Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[Komal Bajaj]

On 5/4/2026 4:33 PM, Krzysztof Kozlowski wrote:
> On Fri, May 01, 2026 at 11:23:46PM +0530, Komal Bajaj wrote:
> > Document the SCM compatible for the Shikra SoC.
> >
> > Signed-off-by: Komal Bajaj <komal.bajaj@xxxxxxxxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> > index 7918d31f58b4..bb1e0a0d1d3c 100644
> > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> > @@ -65,6 +65,7 @@ properties:
> >             - qcom,scm-sdx55
> >             - qcom,scm-sdx65
> >             - qcom,scm-sdx75
> > +          - qcom,scm-shikra
> >             - qcom,scm-sm6115
> >             - qcom,scm-sm6125
> >             - qcom,scm-sm6350
> > @@ -146,6 +147,7 @@ allOf:
> >                 - qcom,scm-msm8974
> >                 - qcom,scm-msm8976
> >                 - qcom,scm-qcm2290
> > +              - qcom,scm-shikra
> >                 - qcom,scm-sm6375
> >       then:
> >         required:
> > @@ -165,6 +167,7 @@ allOf:
> >                 - qcom,scm-msm8660
> >                 - qcom,scm-msm8960
> >                 - qcom,scm-qcm2290
> > +              - qcom,scm-shikra
> >                 - qcom,scm-sm6375
> This looks wrong or the diff hunks are confusing. Aren't you changing
> one if:then: block for clocks and then second different one which
> disallows clocks?
>
> dtbs_check on your DTS would tell you...

The two hunks touch two separate allOf blocks:

- Block 1 (required: [clocks, clock-names]): SoCs that need clocks at all
- Block 2 (clock-names: [core], clocks maxItems: SoCs using exactly one 
clock named core

Both hunks are intentional.
Verified with dtbs_check — no complaints.

Thanks
Komal

> Best regards,
> Krzysztof