Re: [PATCH] dt-bindings: firmware: qcom,scm: Document SCM on Shikra SoC

[Krzysztof Kozlowski]

On 08/05/2026 08:24, Komal Bajaj wrote:
>>>       then:
>>>         required:
>>> @@ -165,6 +167,7 @@ allOf:
>>>                 - qcom,scm-msm8660
>>>                 - qcom,scm-msm8960
>>>                 - qcom,scm-qcm2290
>>> +              - qcom,scm-shikra
>>>                 - qcom,scm-sm6375
>> This looks wrong or the diff hunks are confusing. Aren't you changing
>> one if:then: block for clocks and then second different one which
>> disallows clocks?
>>
>> dtbs_check on your DTS would tell you...
> 
> The two hunks touch two separate allOf blocks:
> 
> - Block 1 (required: [clocks, clock-names]): SoCs that need clocks at all
> - Block 2 (clock-names: [core], clocks maxItems: SoCs using exactly one 
> clock named core
> 
> Both hunks are intentional.
> Verified with dtbs_check — no complaints.

Yes, you are right.

Best regards,
Krzysztof