Re: [PATCH v3] iio: adc: ad7192: replace usleep_range() with fsleep()
From: Andy Shevchenko
Date: Mon May 11 2026 - 03:42:26 EST
On Sun, May 10, 2026 at 04:39:21PM +0500, Stepan Ionichev wrote:
> The AD7192 datasheet (Rev. A, page 34, RESET section) says:
> "When a reset is initiated, the user must allow a period of
> 500 us before accessing any of the on-chip registers."
> fsleep(500) expands to the same usleep_range(500, 1000) and
> keeps the 500 us minimum.
>
> Drop the redundant "/* Wait for at least 500us */" comment.
> No functional change.
Same comment as per other patch.
> Signed-off-by: Stepan Ionichev <sozdayvek@xxxxxxxxx>
> ---
> v3:
> - Cite AD7192 datasheet for the 500 us minimum (per Andy)
To have it in the code comment is much more important.
> - Add this changelog (was missing in v2)
...
> if (ret < 0)
> return ret;
+ blank line
+ comment as per datasheet
> - usleep_range(500, 1000); /* Wait for at least 500us */
> + fsleep(500);
--
With Best Regards,
Andy Shevchenko